[codex] Store compact window id in rollout - #27264
Merged
Merged
Conversation
pakrym-oai
marked this pull request as ready for review
June 9, 2026 23:41
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a0435c29b1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
pakrym-oai
force-pushed
the
pakrym/compact-window-id
branch
4 times, most recently
from
June 10, 2026 12:45
6dd5268 to
b3ec755
Compare
pakrym-oai
force-pushed
the
pakrym/compact-window-id
branch
from
June 10, 2026 12:48
b3ec755 to
97d1986
Compare
pakrym-oai
force-pushed
the
pakrym/compact-window-id
branch
from
June 10, 2026 13:09
97d1986 to
f99614b
Compare
owenlin0
approved these changes
Jun 10, 2026
owenlin0
left a comment
Contributor
There was a problem hiding this comment.
nice, getting rid of state in model_client here too 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Compaction window identity is part of session history, not model-client transport state. Persisting it with the compacted rollout item lets resumed threads continue from the reconstructed window without keeping mutable window state on
ModelClient.What changed
window_idtoCompactedItemand stamp it whenreplace_compacted_historyinstalls compacted history.AutoCompactWindow/SessionState;ModelClientnow receives the request window id from callers instead of storing it.window_idfrom rollout reconstruction for resume. Reconstruction uses the newest surviving compacted item's storedwindow_idwhen present, and falls back to the legacy compacted-item count when it is absent.Validation
cargo check -p codex-core --tests