[5/6] Add Python goal control integration coverage - #27263
Conversation
|
This change is part of the following stack: Change managed by git-spice. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3685c8ed19
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| import pytest | ||
| from app_server_harness import ( | ||
| AppServerHarness, | ||
| SseGate, |
There was a problem hiding this comment.
Define the SSE gate helper before using it
In this commit, SseGate is imported from app_server_harness, but that module does not define or export it, and its enqueue_sse method also has no gate parameter. As a result, pytest fails during collection of this new test file with an import error before any SDK tests can run.
Useful? React with 👍 / 👎.
122249c to
a0de197
Compare
e503a00 to
18ae017
Compare
18ae017 to
879c090
Compare
|
Closing this pull request because it has had no updates for more than 14 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
Why
Steering and interruption must continue to target the active physical turn while callers observe one stable logical goal handle.
What
Add real app-server integration coverage for:
This is a test-only PR. It does not change production code, generated types, or generation scripts.
Test plan