feat: use provider defaults for memory models - #27129
Merged
Merged
Conversation
celia-oai
force-pushed
the
codex/bedrock-memory-model-defaults
branch
from
June 9, 2026 05:37
f1da878 to
00f1e54
Compare
celia-oai
marked this pull request as ready for review
June 9, 2026 18:00
jif-oai
approved these changes
Jun 9, 2026
celia-oai
force-pushed
the
codex/bedrock-memory-model-defaults
branch
3 times, most recently
from
June 9, 2026 19:29
e018493 to
0054078
Compare
celia-oai
force-pushed
the
codex/bedrock-memory-model-defaults
branch
6 times, most recently
from
June 9, 2026 23:04
ce515fd to
b9d00a1
Compare
celia-oai
force-pushed
the
codex/bedrock-memory-model-defaults
branch
2 times, most recently
from
June 9, 2026 23:35
34333a2 to
6936ccd
Compare
celia-oai
force-pushed
the
codex/bedrock-memory-model-defaults
branch
from
June 9, 2026 23:42
6936ccd to
717e4b2
Compare
celia-oai
enabled auto-merge (squash)
June 9, 2026 23:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Memory startup used hardcoded OpenAI model slugs for extraction and consolidation. That works for the default OpenAI-compatible path, but provider-specific backends can require different model identifiers. In particular, Amazon Bedrock should use its Bedrock model ID for these background memory requests instead of the OpenAI
gpt-5.4-mini/gpt-5.4slugs.What Changed
approval_review_preferred_model.ModelProvider.openai.gpt-5.4through Bedrock’s provider-specific model ID.memories.extract_modelandmemories.consolidation_modelconfig overrides taking precedence.#closes #26288