Skip to content

feat: use provider defaults for memory models - #27129

Merged
celia-oai merged 4 commits into
mainfrom
codex/bedrock-memory-model-defaults
Jun 9, 2026
Merged

feat: use provider defaults for memory models#27129
celia-oai merged 4 commits into
mainfrom
codex/bedrock-memory-model-defaults

Conversation

@celia-oai

@celia-oai celia-oai commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Why

Memory startup used hardcoded OpenAI model slugs for extraction and consolidation. That works for the default OpenAI-compatible path, but provider-specific backends can require different model identifiers. In particular, Amazon Bedrock should use its Bedrock model ID for these background memory requests instead of the OpenAI gpt-5.4-mini / gpt-5.4 slugs.

What Changed

  • Added provider-owned preferred memory model methods alongside approval_review_preferred_model.
  • Updated memory extraction and consolidation to resolve their default model through the active ModelProvider.
  • Added Amazon Bedrock overrides so both memory stages use openai.gpt-5.4 through Bedrock’s provider-specific model ID.
  • Kept explicit memories.extract_model and memories.consolidation_model config overrides taking precedence.
  • Added startup coverage for default OpenAI and Bedrock memory model selection.

#closes #26288

@celia-oai
celia-oai force-pushed the codex/bedrock-memory-model-defaults branch from f1da878 to 00f1e54 Compare June 9, 2026 05:37
@celia-oai celia-oai changed the title Use provider defaults for memory models feat: use provider defaults for memory models Jun 9, 2026
@celia-oai
celia-oai marked this pull request as ready for review June 9, 2026 18:00
@celia-oai
celia-oai requested a review from jif-oai June 9, 2026 18:00

@jif-oai jif-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok after my comments

Comment thread codex-rs/memories/write/src/startup_tests.rs Outdated
Comment thread codex-rs/model-provider/src/provider.rs Outdated
Comment thread codex-rs/model-provider/src/amazon_bedrock/mod.rs Outdated
@celia-oai
celia-oai force-pushed the codex/bedrock-memory-model-defaults branch 3 times, most recently from e018493 to 0054078 Compare June 9, 2026 19:29
@celia-oai
celia-oai force-pushed the codex/bedrock-memory-model-defaults branch 6 times, most recently from ce515fd to b9d00a1 Compare June 9, 2026 23:04
@celia-oai
celia-oai force-pushed the codex/bedrock-memory-model-defaults branch 2 times, most recently from 34333a2 to 6936ccd Compare June 9, 2026 23:35
@celia-oai
celia-oai force-pushed the codex/bedrock-memory-model-defaults branch from 6936ccd to 717e4b2 Compare June 9, 2026 23:42
@celia-oai
celia-oai enabled auto-merge (squash) June 9, 2026 23:48
@celia-oai
celia-oai merged commit 51fc4b0 into main Jun 9, 2026
31 checks passed
@celia-oai
celia-oai deleted the codex/bedrock-memory-model-defaults branch June 9, 2026 23:49
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Codex Desktop with Bedrock uses unsupported gpt-5.4-mini for helper turns

2 participants