[codex] Break down between-sampling overhead - #27115
Closed
aibrahim-oai wants to merge 2 commits into
Closed
Conversation
aibrahim-oai
force-pushed
the
codex/turn-sampling-phases
branch
from
June 9, 2026 03:44
0e440c2 to
46dce52
Compare
aibrahim-oai
force-pushed
the
codex/turn-sampling-phases
branch
from
June 9, 2026 04:19
46dce52 to
7c9c053
Compare
aibrahim-oai
force-pushed
the
codex/turn-sampling-phases
branch
from
June 9, 2026 07:22
7c9c053 to
2774012
Compare
This was referenced Jun 11, 2026
## Summary - add optional `comp_hash` metadata to `ModelInfo` - update `ModelInfo` fixtures for the shared schema change - keep older model responses compatible by defaulting the field to `None` ## Why The models endpoint needs an opaque identifier for compaction-compatible model configurations. This PR only exposes that value in model metadata; it does not add it to turn context or change runtime behavior. Follow-up #27520 carries the value through turn context and rollouts, then uses it to trigger compaction. ## Stack - based on #27115 - functionality follow-up: #27520 ## Testing - `just test -p codex-protocol model_info_defaults_availability_nux_to_none_when_omitted` - `just fix -p codex-core -p codex-protocol -p codex-analytics -p codex-models-manager`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
otherafter_last_sampling_msand excluding tool-blocking timeSemantics
between_sampling_overhead_msTesting
just test -p codex-core turn_profile_just test -p codex-analyticsjust test -p codex-app-server turn_start_tracks_turn_event_analyticsjust test -p codex-app-server turn_profile_just fix -p codex-corejust fix -p codex-analyticsjust fix -p codex-app-serverUV_CACHE_DIR=/tmp/codex-uv-cache just fmt