Skip to content

[codex] Ignore pending PR review comments - #27080

Merged
anp-oai merged 1 commit into
mainfrom
codex/ignore-pending-review-comments
Jun 9, 2026
Merged

[codex] Ignore pending PR review comments#27080
anp-oai merged 1 commit into
mainfrom
codex/ignore-pending-review-comments

Conversation

@anp-oai

@anp-oai anp-oai commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Why

The PR babysitter could surface inline comments from a GitHub review that was still in the PENDING state. That allowed Codex to start acting on feedback before the reviewer submitted it.

What changed

  • Correlate inline comments with their parent review and ignore pending reviews and their comments.
  • Remove pending review IDs from saved watcher state so the feedback surfaces normally after publication.
  • Update the skill instructions and add regression coverage for the draft-to-published transition.

Validation

  • python3 -m pytest .codex/skills/babysit-pr/scripts/test_gh_pr_watch.py
  • Skill package validation with quick_validate.py
  • Live verification on [codex] Test extension API contracts #26835: the draft comment stayed hidden and surfaced after the review was submitted.

@anp-oai
anp-oai marked this pull request as ready for review June 8, 2026 23:37

@etraut-openai etraut-openai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anp-oai
anp-oai merged commit a770e5b into main Jun 9, 2026
31 checks passed
@anp-oai
anp-oai deleted the codex/ignore-pending-review-comments branch June 9, 2026 15:29
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants