[codex] add /import for external agents#27071
Merged
Merged
Conversation
This was referenced Jun 8, 2026
81d31e7 to
ff65430
Compare
96a3732 to
814446e
Compare
alexsong-oai
approved these changes
Jun 9, 2026
stefanstokic-oai
added a commit
that referenced
this pull request
Jun 10, 2026
## Why External-agent import should be initiated deliberately instead of interrupting eligible TUI startups. This cleanup removes the blocking startup flow before the replacement import experience is introduced later in the stack. ## What changed - remove the startup-blocking external-agent migration prompt - remove the now-unused external migration feature gate - remove the obsolete TUI app-server migration wrappers - retain the dormant picker behind a module-scoped dead-code allowance until the next stack item wires it back in - keep normal TUI startup focused on entering Codex immediately ## Validation - `bazel build --config=clippy //codex-rs/tui:tui //codex-rs/tui:tui-unit-tests-bin` - `just test -p codex-tui external_agent_config_migration` (8 passed) - `just test -p codex-tui` (2,786 passed, 12 unrelated local environment-sensitive failures, 4 skipped) - `just fix -p codex-tui` - `just fmt` ## Stack 1. [#27064](#27064): remove the startup migration flow 2. [#27065](#27065): extract the picker renderer 3. [#27070](#27070): add the external-agent import picker UX 4. [#27071](#27071): expose the flow through `/import` **This PR is stack item 1.**
stefanstokic-oai
added a commit
that referenced
this pull request
Jun 10, 2026
## Why The external-agent import picker is easier to review when its rendering refactor lands separately from new state and interaction behavior. This layer is intended to be behavior-neutral. ## What changed - extract external-agent migration rendering into a dedicated `render` module - preserve existing behavior while separating presentation from interaction logic - establish a smaller foundation for the import picker UX in the next PR ## Validation - `just test -p codex-tui external_agent_config_migration` (10 passed) ## Stack 1. [#27064](#27064): remove the startup migration flow 2. [#27065](#27065): extract the picker renderer 3. [#27070](#27070): add the external-agent import picker UX 4. [#27071](#27071): expose the flow through `/import` **This PR is stack item 2.** Draft while the lower stack dependency is reviewed.
ff65430 to
72c495a
Compare
stefanstokic-oai
added a commit
that referenced
this pull request
Jun 10, 2026
## Why Users need to understand what external-agent data Codex detected, what is selected, and how to proceed before an import begins. The updated picker makes focus, selection state, and the submission path explicit while preserving the existing import backend. ## What changed - replace the old migration prompt with a two-step external-agent import picker - add a customize view with explicit item focus, selection state, counts, and a review action - separate detected import data into a view model - add Unix and Windows snapshots for prompt, item-focus, and action-focus states ## Validation - `just test -p codex-tui external_agent_config_migration` (10 passed) - manually exercised an isolated TUI fixture covering customization, selection toggles, review, import, repeated invocation, and session resume - the broader `just test -p codex-tui` run passed 2,805 tests, with 2 unrelated guardian feature-flag failures and 4 skipped tests ## Review note This is the largest layer in the stack because the interaction state, rendering changes, and required snapshots move together. It remains a draft in case reviewers prefer a further presentation/state split. ## Stack 1. [#27064](#27064): remove the startup migration flow 2. [#27065](#27065): extract the picker renderer 3. [#27070](#27070): add the external-agent import picker UX 4. [#27071](#27071): expose the flow through `/import` **This PR is stack item 3.** Draft while the lower stack dependencies are reviewed.
814446e to
15bbbdf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
External-agent import should be discoverable and deliberate without blocking startup or claiming the public
codex [PROMPT]CLI namespace. The slash command keeps the flow local to the interactive TUI and reuses the existing app-server import API.What changed
/importslash commandValidation
just test -p codex-tui external_agent_config_migration(10 passed)CODEX_HOMEjust test -p codex-tuirun passed 2,805 tests, with 2 unrelated guardian feature-flag failures and 4 skipped testsDraft follow-ups
Stack
/importThis PR is stack item 4. Draft while the lower stack dependencies are reviewed.