[codex-analytics] add extensible feature thread sources - #27063
Merged
Conversation
marksteinbrick-oai
marked this pull request as ready for review
June 9, 2026 02:30
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1bf0639660
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
marksteinbrick-oai
force-pushed
the
mark.steinbrick/thread-source-feature
branch
from
June 9, 2026 16:14
1bf0639 to
41ac94d
Compare
rhan-oai
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ThreadSourcecurrently defines a closed set of core-owned valuescodex-rsprotocol changesWhat Changed
ThreadSource::Feature(String)for app-owned thread source values"automation""automation"producesthread_source="automation"in analyticsuser,subagent, andmemory_consolidationas explicit core-owned values and regenerates the app-server schemas and TypeScript bindingsVerification
just write-app-server-schemacargo check --workspacejust test -p codex-protocol feature_thread_source_serializes_as_its_app_owned_labeljust test -p codex-app-server-protocol thread_sources_round_trip_as_scalar_labelscargo test -p codex-analytics thread_initialized_event_serializes_expected_shapejust fmt