Skip to content

[codex] Characterize global instruction lifecycle - #26830

Merged
anp-oai merged 14 commits into
mainfrom
codex/global-instructions-tests
Jun 9, 2026
Merged

[codex] Characterize global instruction lifecycle#26830
anp-oai merged 14 commits into
mainfrom
codex/global-instructions-tests

Conversation

@anp-oai

@anp-oai anp-oai commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Why

Global instruction behavior spans thread creation, resume, forks, subagents, and compaction. Characterization coverage is needed before changing those semantics so preserved history can be distinguished from newly loaded configuration.

What changed

  • Extends the existing agents_md suite with fresh-thread, warning, resume, fork, and subagent lifecycle coverage.
  • Extends the existing compact suite with manual, mid-turn, and remote-v2 compaction coverage.
  • Asserts rendered instruction fragments, reported source paths, and structured request history before and after instruction-file mutations.

Comment thread codex-rs/core/tests/suite/global_instructions_regression.rs Outdated
Comment thread codex-rs/app-server/tests/suite/v2/thread_fork.rs Outdated
Comment thread codex-rs/app-server/tests/suite/v2/thread_fork.rs Outdated
Comment thread codex-rs/core/tests/suite/user_instructions.rs Outdated
Comment thread codex-rs/core/tests/suite/user_instructions.rs Outdated
Comment thread codex-rs/core/tests/suite/user_instructions.rs Outdated
anp-oai added a commit that referenced this pull request Jun 7, 2026
anp-oai added a commit that referenced this pull request Jun 7, 2026
Comment thread codex-rs/core/tests/suite/user_instructions.rs Outdated
Comment thread codex-rs/core/tests/suite/user_instructions.rs Outdated
Comment thread codex-rs/core/tests/suite/user_instructions.rs Outdated
@anp-oai
anp-oai marked this pull request as ready for review June 7, 2026 01:05
@anp-oai
anp-oai requested a review from a team as a code owner June 7, 2026 01:05
@anp-oai

anp-oai commented Jun 7, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9bc1560c4b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/core/tests/suite/user_instructions.rs Outdated
Comment thread codex-rs/app-server/tests/suite/v2/thread_fork.rs Outdated
Comment thread codex-rs/core/tests/suite/compact_remote_parity.rs Outdated
Comment thread codex-rs/core/tests/suite/global_instructions.rs Outdated
Comment thread codex-rs/core/tests/suite/user_instructions.rs Outdated
Comment thread codex-rs/core/tests/suite/user_instructions.rs Outdated
Comment thread codex-rs/core/tests/suite/user_instructions.rs Outdated
@anp-oai
anp-oai force-pushed the codex/global-instructions-tests branch from 71569e6 to ec0b20f Compare June 9, 2026 19:16
@anp-oai
anp-oai force-pushed the codex/global-instructions-tests branch from ec0b20f to 11babeb Compare June 9, 2026 20:14
@anp-oai
anp-oai enabled auto-merge (squash) June 9, 2026 20:51
@anp-oai
anp-oai merged commit 9e3081b into main Jun 9, 2026
49 of 57 checks passed
@anp-oai
anp-oai deleted the codex/global-instructions-tests branch June 9, 2026 20:51
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants