Reduce TUI legacy core dependencies - #26711
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: df080a9d33
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 02c37810b7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
02c3781 to
8d2efbb
Compare
8d2efbb to
08811b5
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 08811b5e35
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,4 +1,5 @@ | |||
| Generate a file named AGENTS.md that serves as a contributor guide for this repository. | |||
| Before writing, check whether AGENTS.md already exists in the current working directory. If it does, do not overwrite or modify it. | |||
There was a problem hiding this comment.
Add integration coverage for /init behavior
Under AGENTS.md Test authoring guidance, agent-logic changes need integration coverage. This line changes /init model behavior by requiring an existing-AGENTS.md check before writing, but the diff only verifies that the TUI queues the prompt, so regressions in the actual agent behavior can still pass. Please add an integration test for existing-AGENTS.md handling.
Useful? React with 👍 / 👎.
Why
The TUI still reached through
app-server-client::legacy_corefor thread-name normalization and project-instruction filename details. In particular, checking the TUI's local filesystem for/initis incorrect for remote app-server sessions, where the server owns the working directory and instruction discovery.What changed
/initshould avoid overwriting project instructionslegacy_corere-exportsVerification
just test -p codex-app-server-clientjust test -p codex-tui slash_init_skips_when_project_instructions_are_loadedjust test -p codex-tuiran 2,799 tests; 2,797 passed and two unrelated guardian feature-flag tests failed reproducibly in untouched codeManual test
Started an app server over WebSocket with a remote workspace containing
AGENTS.md, then connected the TUI using--remote. After confirmingthread/startreturned the file ininstructionSources, deletedAGENTS.mdand ran/initin the existing session.The TUI still reported that project instructions already existed and skipped
/init. The trace contained noturn/startrequest, confirming the decision came from app-server session state rather than a new client-local filesystem check.