PAC 1 - Add system proxy feature config surface#26706
Conversation
02c4962 to
9175bbb
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
9b202fb to
ffb3961
Compare
fcoury-oai
left a comment
There was a problem hiding this comment.
Codex found 3 potential issues and I left them inline.
The happy path testing worked as expected, so I am approving the PR and leaving at your discretion whether to address the comments.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 99745d7f62
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Introduces the default-off
respect_system_proxyfeature flag used to gate first-class system PAC/proxy support for Codex-owned native clients.With the feature disabled or absent, behavior remains unchanged. This PR establishes the configuration and managed-requirement surface; proxy discovery and request routing are implemented by follow-up PRs.
Configuration
User configuration uses the standard boolean feature form:
Managed feature requirements use the corresponding boolean key. The effective runtime configuration is exposed as a boolean and defaults to
false.Implementation
respect_system_proxyas an under-development, default-off feature.Config.respect_system_proxy.features.respect_system_proxyfrom project-local configuration.End-user behavior
Test coverage
Covers scalar configuration and CLI override resolution, managed requirement constraints, bootstrap resolution, and project-local filtering.