Skip to content

TUI Plugin Sharing 4 - cover remote plugin catalog flows - #26704

Merged
canvrno-oai merged 13 commits into
mainfrom
canvrno/plugin_sharing_tui_stack_pr4_remote_catalog_tests
Jun 23, 2026
Merged

TUI Plugin Sharing 4 - cover remote plugin catalog flows#26704
canvrno-oai merged 13 commits into
mainfrom
canvrno/plugin_sharing_tui_stack_pr4_remote_catalog_tests

Conversation

@canvrno-oai

@canvrno-oai canvrno-oai commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Remote plugin catalogs now span workspace, shared, and local sources, so their TUI behavior needs focused regression coverage across loading, navigation, actions, and refreshes.

This PR:

  • Covers product labels and rendered loading/error states for Workspace, Shared with me, Shared with me (link), and Local tabs, including tab persistence across refresh and detail navigation.
  • Covers remote/local deduplication, Installed-tab remote detail routing, marketplace load-error handling, and disabled install/uninstall navigation.
  • Adds a full detail snapshot for local shared-plugin metadata plus focused snapshots for marketplace labels and admin-disabled status.
  • Verifies shared plugins remain eligible for mentions and successful uninstalls trigger a catalog refresh.

@canvrno-oai canvrno-oai changed the title [codex] tui: cover remote plugin catalog flows TUI Plugin sharing - cover remote plugin catalog flows Jun 6, 2026
@canvrno-oai
canvrno-oai force-pushed the canvrno/plugin_sharing_tui_stack_pr3_remote_catalog_ui branch from 9bfd656 to 8798c0c Compare June 6, 2026 00:44
@canvrno-oai
canvrno-oai force-pushed the canvrno/plugin_sharing_tui_stack_pr4_remote_catalog_tests branch from 6fae044 to 3c53274 Compare June 6, 2026 00:44
@canvrno-oai
canvrno-oai force-pushed the canvrno/plugin_sharing_tui_stack_pr3_remote_catalog_ui branch from 8798c0c to 834ca6a Compare June 8, 2026 17:49
@canvrno-oai
canvrno-oai force-pushed the canvrno/plugin_sharing_tui_stack_pr4_remote_catalog_tests branch from 3c53274 to 8f3923a Compare June 8, 2026 17:49
@canvrno-oai
canvrno-oai force-pushed the canvrno/plugin_sharing_tui_stack_pr3_remote_catalog_ui branch from 834ca6a to 8630a7a Compare June 8, 2026 18:03
@canvrno-oai
canvrno-oai force-pushed the canvrno/plugin_sharing_tui_stack_pr4_remote_catalog_tests branch 3 times, most recently from a8c121a to 4d5c661 Compare June 8, 2026 19:01
@canvrno-oai
canvrno-oai force-pushed the canvrno/plugin_sharing_tui_stack_pr3_remote_catalog_ui branch from ba4dd5b to 34ba4ee Compare June 8, 2026 20:22
@canvrno-oai
canvrno-oai force-pushed the canvrno/plugin_sharing_tui_stack_pr4_remote_catalog_tests branch from a3c44df to f543572 Compare June 8, 2026 20:23
@canvrno-oai canvrno-oai changed the title TUI Plugin sharing - cover remote plugin catalog flows TUI Plugin Sharing 4 Jun 9, 2026
@canvrno-oai canvrno-oai changed the title TUI Plugin Sharing 4 TUI Plugin Sharing 4 - cover remote plugin catalog flows Jun 9, 2026
@canvrno-oai
canvrno-oai force-pushed the canvrno/plugin_sharing_tui_stack_pr3_remote_catalog_ui branch 2 times, most recently from 40f1ca8 to f7b6f35 Compare June 10, 2026 03:56
@canvrno-oai
canvrno-oai force-pushed the canvrno/plugin_sharing_tui_stack_pr4_remote_catalog_tests branch from f543572 to 4cba5df Compare June 10, 2026 04:02
@canvrno-oai
canvrno-oai force-pushed the canvrno/plugin_sharing_tui_stack_pr4_remote_catalog_tests branch from 10bc962 to 311d253 Compare June 17, 2026 01:56
canvrno-oai added a commit that referenced this pull request Jun 17, 2026
canvrno-oai added a commit that referenced this pull request Jun 17, 2026
@canvrno-oai
canvrno-oai force-pushed the canvrno/plugin_sharing_tui_stack_pr3_remote_catalog_ui branch from 3e591c2 to ce95121 Compare June 17, 2026 19:15
canvrno-oai added a commit that referenced this pull request Jun 17, 2026
canvrno-oai added a commit that referenced this pull request Jun 17, 2026
@canvrno-oai
canvrno-oai force-pushed the canvrno/plugin_sharing_tui_stack_pr4_remote_catalog_tests branch from f8d7100 to d0ca565 Compare June 17, 2026 20:07
Base automatically changed from canvrno/plugin_sharing_tui_stack_pr3_remote_catalog_ui to main June 22, 2026 17:30
canvrno-oai added a commit that referenced this pull request Jun 22, 2026
@canvrno-oai
canvrno-oai force-pushed the canvrno/plugin_sharing_tui_stack_pr4_remote_catalog_tests branch from deb9a0b to 479a0dd Compare June 22, 2026 17:36
canvrno-oai added a commit that referenced this pull request Jun 22, 2026
canvrno-oai added a commit that referenced this pull request Jun 22, 2026
canvrno-oai added a commit that referenced this pull request Jun 22, 2026
@canvrno-oai
canvrno-oai force-pushed the canvrno/plugin_sharing_tui_stack_pr4_remote_catalog_tests branch from 479a0dd to 9493e4a Compare June 22, 2026 17:37
@canvrno-oai
canvrno-oai force-pushed the canvrno/plugin_sharing_tui_stack_pr4_remote_catalog_tests branch from 9493e4a to c433b9b Compare June 22, 2026 17:46
@canvrno-oai

Copy link
Copy Markdown
Contributor Author

@codex review

@canvrno-oai
canvrno-oai marked this pull request as ready for review June 22, 2026 22:16
@canvrno-oai

canvrno-oai commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

@codex review! please

@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: c9252e9168

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@etraut-openai etraut-openai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor comments for your consideration, but overall looks good!

Comment thread codex-rs/tui/src/chatwidget/tests/plugin_catalog_tests.rs
Comment thread codex-rs/tui/src/chatwidget/tests/plugin_catalog_tests.rs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b421101b06

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/tui/src/custom_terminal.rs
@canvrno-oai
canvrno-oai merged commit fbd575a into main Jun 23, 2026
31 checks passed
@canvrno-oai
canvrno-oai deleted the canvrno/plugin_sharing_tui_stack_pr4_remote_catalog_tests branch June 23, 2026 00:31
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants