Skip to content

TUI Plugin Sharing 1 - add remote plugin identity#26701

Merged
canvrno-oai merged 6 commits into
mainfrom
canvrno/plugin_sharing_tui_stack_pr1_remote_identity
Jun 9, 2026
Merged

TUI Plugin Sharing 1 - add remote plugin identity#26701
canvrno-oai merged 6 commits into
mainfrom
canvrno/plugin_sharing_tui_stack_pr1_remote_identity

Conversation

@canvrno-oai

@canvrno-oai canvrno-oai commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

This starts the shared-plugin TUI stack by teaching the existing plugin popup flows to address plugins from either a local marketplace path or a remote marketplace name. The visible surface stays intentionally narrow so later catalog work can build on stable remote request identity without adding share-management UI.

  • Adds remote-capable detail/install/uninstall request routing for plugin popup actions.
  • Uses remote plugin IDs for remote install and uninstall while preserving local plugin IDs and paths.
  • Keeps remote detail views available when a marketplace has no filesystem path.
  • Blocks admin-disabled plugin installs and toggle affordances in the existing flows.

@canvrno-oai canvrno-oai changed the title [codex] tui: add remote plugin identity TUI Plugin sharing - add remote plugin identity Jun 6, 2026
@canvrno-oai canvrno-oai force-pushed the canvrno/plugin_sharing_tui_stack_pr1_remote_identity branch from 20d8d54 to ccf0f0d Compare June 8, 2026 18:03
@canvrno-oai

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ccf0f0d989

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/tui/src/chatwidget/tests/popups_and_settings.rs
@canvrno-oai canvrno-oai marked this pull request as ready for review June 9, 2026 20:54
@canvrno-oai canvrno-oai changed the title TUI Plugin sharing - add remote plugin identity TUI Plugin Sharing 1 Jun 9, 2026
@canvrno-oai canvrno-oai changed the title TUI Plugin Sharing 1 TUI Plugin Sharing 1 - add remote plugin identity Jun 9, 2026
Remote { marketplace_name: String },
}

impl PluginLocation {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe MarketplaceRef?

@xl-openai xl-openai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM!

@canvrno-oai canvrno-oai merged commit fb8f1ea into main Jun 9, 2026
46 of 47 checks passed
@canvrno-oai canvrno-oai deleted the canvrno/plugin_sharing_tui_stack_pr1_remote_identity branch June 9, 2026 23:34
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants