[rmcp-client] Classify OAuth refresh and storage failures correctly - #26519
Closed
anp-oai wants to merge 3 commits into
Closed
[rmcp-client] Classify OAuth refresh and storage failures correctly#26519anp-oai wants to merge 3 commits into
anp-oai wants to merge 3 commits into
Conversation
This was referenced Jun 5, 2026
Contributor
Author
|
handing this off for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Make OAuth startup failures distinguish genuine reauthentication requirements from transient provider and credential-storage failures, while retaining rotated credentials across retryable write failures and startup cancellation.
User-visible behavior
Before
After
invalid_grant,AuthorizationRequired, or missing refresh token produces actionable reauthentication guidance. Provider descriptions associated with revoked credentials are intentionally not displayed.Concrete implementation
AuthorizationRequired, missing refresh tokens, and an exact RMCPinvalid_granterror code as reauthentication; preserve bounded transient and storage causes without leaking revoked-token descriptions.Validation not covered by CI
just test -p codex-rmcp-client --test streamable_http_oauth_startupjust test -p codex-rmcp-client --libjust test -p codex-mcpjust fix -p codex-rmcp-clientjust fix -p codex-mcpjust fmtThe full
just test -p codex-rmcp-clientrun passed 67/68 tests; the unrelatedstreamable_http_remotetest could not locate a builtcodexbinary in this worktree.Deferred scope
Autocredential-store fallback policy is unchanged.