Warn when hooks.json has unsupported top-level fields - #26426
Merged
Conversation
abhinav-oai
force-pushed
the
abhinav/warn-malformed-hooks-json
branch
from
June 4, 2026 17:37
7ecd123 to
e328232
Compare
eternal-openai
approved these changes
Jun 11, 2026
…d-hooks-json # Conflicts: # codex-rs/exec/src/lib.rs # codex-rs/hooks/src/engine/mod_tests.rs
abhinav-oai
enabled auto-merge (squash)
June 11, 2026 22:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #25875.
Summary
hooks.jsonaccepted unknown top-level fields. A file withSessionStartat the root parsed as an empty hook configuration without warning.Repro
{ "SessionStart": [...] }Previously: zero hooks, zero warnings.
Now:
The supported shape remains:
{ "hooks": { "SessionStart": [...] } }Fix
Reject unknown top-level fields and surface the parse warning in human and JSONL
codex execoutput.