[codex] Retry streamable HTTP initialize failures by ssetty-oai · Pull Request #25147 · openai/codex

ssetty-oai · 2026-05-29T20:16:31Z

Summary

Retry transient streamable HTTP failures during RMCP startup when the failure happens while sending the initialize request.
Retry transient streamable HTTP failures for tools/list, which is read-only and safe to replay.
Cover both retryable HTTP statuses and request-layer failures where no HTTP status is returned.
Surface retryable HTTP statuses from the streamable HTTP adapter as typed client errors.
Add integration coverage for initialize retry, tools/list retry, no-status request failure retry, and non-retryable initialize status.

Root cause

The observed codex_apps failures can happen before normal tool execution: RMCP startup fails while sending initialize, or the first read-only tools/list fails after startup. Retrying hosted_apps_bridge tools/call would not cover initialize and would risk replaying side-effecting tool calls. This change retries the streamable HTTP handshake itself, recreates the transport between initialize attempts, and retries only tools/list among post-initialize service operations.

Validation

cargo fmt --package codex-rmcp-client
cargo test -p codex-rmcp-client --test streamable_http_recovery

ssetty-oai · 2026-05-29T20:28:49Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 098753766a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ssetty-oai · 2026-05-29T22:54:34Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f513db0ac3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ssetty-oai · 2026-06-02T03:30:23Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9649a2eaee

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ssetty-oai · 2026-06-04T23:58:26Z

@codex review

chatgpt-codex-connector · 2026-06-05T00:01:37Z

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ssetty-oai · 2026-06-05T00:04:18Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d00ea62d33

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ssetty-oai · 2026-06-05T00:36:30Z

@codex review

chatgpt-codex-connector · 2026-06-05T00:40:20Z

Codex Review: Didn't find any major issues. Can't wait for the next one!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ssetty-oai · 2026-06-05T00:54:40Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 00ee46ca9f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ssetty-oai · 2026-06-05T01:09:56Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a7ddbf9a88

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ssetty-oai · 2026-06-09T15:06:45Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1f6a75d2ac

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ssetty-oai · 2026-06-09T15:26:30Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9dfb4be0ec

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ssetty-oai · 2026-06-09T15:44:39Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ce34025915

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ssetty-oai · 2026-06-09T16:00:31Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7a381f591d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ssetty-oai · 2026-06-09T16:15:07Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4f29a9e89e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-06-09T16:22:46Z

+pub(super) const STREAMABLE_HTTP_RETRY_DELAYS_MS: [u64; 2] = [250, 1_000];
+
+impl RmcpClient {
+    pub(super) async fn connect_pending_transport_with_initialize_retries(


Split non-mechanical retry change into stages

This non-mechanical retry PR changes 1,024 lines across retry logic, adapter propagation, test support, and integration coverage, exceeding the repo’s review-size guidance; please split it into staged PRs. guidance

Useful? React with 👍 / 👎.

ssetty-oai marked this pull request as ready for review May 29, 2026 20:31

ssetty-oai force-pushed the dev/ssetty/retry-rmcp-initialize branch from 0987537 to 71fe20b Compare May 29, 2026 20:35

chatgpt-codex-connector Bot reviewed May 29, 2026

View reviewed changes

Comment thread codex-rs/rmcp-client/src/rmcp_client.rs Outdated

ssetty-oai force-pushed the dev/ssetty/retry-rmcp-initialize branch from 71fe20b to 4d1e23e Compare May 29, 2026 21:02

ssetty-oai marked this pull request as draft May 29, 2026 21:02

ssetty-oai marked this pull request as ready for review May 29, 2026 21:04

ssetty-oai force-pushed the dev/ssetty/retry-rmcp-initialize branch from 4d1e23e to f513db0 Compare May 29, 2026 21:20

ssetty-oai marked this pull request as draft May 29, 2026 21:20

ssetty-oai marked this pull request as ready for review May 29, 2026 22:57

ssetty-oai force-pushed the dev/ssetty/retry-rmcp-initialize branch from f513db0 to 9649a2e Compare May 29, 2026 23:01

chatgpt-codex-connector Bot reviewed May 29, 2026

View reviewed changes

Comment thread codex-rs/rmcp-client/src/rmcp_client.rs Outdated

chatgpt-codex-connector Bot reviewed Jun 2, 2026

View reviewed changes

Comment thread codex-rs/rmcp-client/src/rmcp_client.rs Outdated

ssetty-oai added a commit that referenced this pull request Jun 5, 2026

codex: fix CI fmt-check recipe on PR #25147

d00ea62

chatgpt-codex-connector Bot reviewed Jun 5, 2026

View reviewed changes

ssetty-oai added a commit that referenced this pull request Jun 5, 2026

codex: fix CI failures on PR #25147

a709d6b

ssetty-oai added a commit that referenced this pull request Jun 5, 2026

codex: address PR review feedback (#25147)

00ee46c

chatgpt-codex-connector Bot reviewed Jun 5, 2026

View reviewed changes

Comment thread codex-rs/rmcp-client/Cargo.toml Outdated

Comment thread sdk/python/pyproject.toml

Comment thread codex-rs/rmcp-client/src/rmcp_client_tests.rs Outdated

ssetty-oai added a commit that referenced this pull request Jun 5, 2026

codex: address follow-up review feedback (#25147)

a7ddbf9

chatgpt-codex-connector Bot reviewed Jun 5, 2026

View reviewed changes

Comment thread codex-rs/rmcp-client/src/http_client_adapter.rs Outdated

Comment thread codex-rs/rmcp-client/Cargo.toml Outdated

Comment thread sdk/python/src/openai_codex/api.py Outdated

Comment thread codex-rs/rmcp-client/src/rmcp_client.rs Outdated

ssetty-oai added a commit that referenced this pull request Jun 5, 2026

codex: fix python SDK signature test (#25147)

a6f9512

ssetty-oai added 12 commits June 9, 2026 08:05

codex: address PR review feedback (#25147)

5f2b14e

codex: address follow-up review feedback (#25147)

d4b8261

codex: fix python SDK signature test (#25147)

daf24cc

codex: narrow retry PR scope (#25147)

b0a300f

codex: remove SDK changes from retry PR (#25147)

6e4c8df

codex: address retry review structure feedback (#25147)

dee789a

codex: fix justfile formatting for CI (#25147)

08503d6

codex: address streamable http retry review feedback (#25147)

75e3421

codex: keep rmcp retry module surgical (#25147)

d1596f4

codex: narrow streamable http initialize retry (#25147)

2e23b88

Persist OAuth state before initialize retry

b8760d3

Remove python SDK changes from retry PR

1f6a75d

ssetty-oai force-pushed the dev/ssetty/retry-rmcp-initialize branch from 9c604c6 to 1f6a75d Compare June 9, 2026 15:06

chatgpt-codex-connector Bot reviewed Jun 9, 2026

View reviewed changes

Comment thread codex-rs/rmcp-client/src/streamable_http_retry.rs

Comment thread codex-rs/rmcp-client/src/rmcp_client.rs

Retry streamable HTTP recovery handshakes

9dfb4be

chatgpt-codex-connector Bot reviewed Jun 9, 2026

View reviewed changes

Comment thread codex-rs/rmcp-client/src/streamable_http_retry.rs

Comment thread codex-rs/rmcp-client/src/http_client_adapter.rs Outdated

Retry tools list transient HTTP failures

ce34025

chatgpt-codex-connector Bot reviewed Jun 9, 2026

View reviewed changes

Comment thread codex-rs/rmcp-client/src/http_client_adapter.rs

Retry initialized notification failures

7a381f5

chatgpt-codex-connector Bot reviewed Jun 9, 2026

View reviewed changes

Comment thread codex-rs/rmcp-client/src/streamable_http_retry.rs

Comment thread codex-rs/rmcp-client/src/http_client_adapter.rs

Cover tools list JSON-RPC retry

4f29a9e

chatgpt-codex-connector Bot reviewed Jun 9, 2026

View reviewed changes

ssetty-oai merged commit 490340f into main Jun 9, 2026
31 checks passed

ssetty-oai deleted the dev/ssetty/retry-rmcp-initialize branch June 9, 2026 22:49

github-actions Bot locked and limited conversation to collaborators Jun 9, 2026

Uh oh!

Conversation

ssetty-oai commented May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Root cause

Validation

Uh oh!

ssetty-oai commented May 29, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ssetty-oai commented May 29, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ssetty-oai commented Jun 2, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ssetty-oai commented Jun 4, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 5, 2026

Uh oh!

ssetty-oai commented Jun 5, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ssetty-oai commented Jun 5, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 5, 2026

Uh oh!

ssetty-oai commented Jun 5, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ssetty-oai commented Jun 5, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ssetty-oai commented Jun 9, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

ssetty-oai commented Jun 9, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

ssetty-oai commented May 29, 2026 •

edited

Loading