Skip to content

Thread Guardian cache key through session #24895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jif-oai merged 1 commit into from
May 28, 2026
+6 −0
Merged

Thread Guardian cache key through session #24895

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions codex-rs/core/src/session/session.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1034,6 +1034,12 @@ impl Session {
config.features.enabled(Feature::RuntimeMetrics),
Self::build_model_client_beta_features_header(config.as_ref()),
attestation_provider,
)
.with_prompt_cache_key_override(
crate::guardian::prompt_cache_key_override_for_review_session(
Comment on lines +1038 to +1039

@chatgpt-codex-connector chatgpt-codex-connector Bot May 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore missing cache-key API before calling it

In this standalone commit, the new chain calls ModelClient::with_prompt_cache_key_override and guardian::prompt_cache_key_override_for_review_session, but neither symbol exists anywhere under codex-rs in this commit; git grep finds only this callsite. Any build of codex-core after applying just this split PR fails before tests, so this session-threading change cannot land independently of the companion API definitions.

Useful? React with 👍 / 👎.

&session_configuration.session_source,
session_configuration.forked_from_thread_id,
),
),
code_mode_service: crate::tools::code_mode::CodeModeService::new(),
environment_manager,
Expand Down
Loading