-
Notifications
You must be signed in to change notification settings - Fork 15.3k
Move plugin and skill warmup into session startup #23535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
937a48c
Make plugin and skill warmup non-blocking
aibrahim-oai 6846393
Move warmup call to session startup
aibrahim-oai 1960204
Move plugin and skill warmup into session init join
aibrahim-oai d947f23
Guard live thread during startup join cancellation
aibrahim-oai 41d2988
Revert "Guard live thread during startup join cancellation"
aibrahim-oai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When session startup is canceled while plugin/skill warmup is slow or blocked, adding
plugin_and_skill_warmup_futto thistokio::join!can leave a completedthread_persistence_futresult holding aLiveThreadbeforeLiveThreadInitGuardis constructed below. Dropping that unguardedLiveThreadskipsdiscard_thread, so the local store can retain a live recorder for a thread that never finished initializing; before this change, this warmup ran before opening thread persistence and did not create that cancellation window.Useful? React with 👍 / 👎.