-
Notifications
You must be signed in to change notification settings - Fork 14.8k
[codex] preserve MCP result meta in McpToolCallItemResult #22946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+58
−0
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
850d228
Preserve MCP result meta in exec JSONL events
miaolin-oai 28a5f8e
Expose MCP result metadata in TypeScript SDK
miaolin-oai e160c81
Merge branch 'main' into codex/preserve-mcp-result-meta
miaolin-oai 21bb509
Fix JSONL metadata test lint
miaolin-oai e189890
Fix rustfmt import ordering
miaolin-oai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding
metaas a normal public field means every existingMcpToolCallItemResult { ... }struct literal must provide it; the integration tests incodex-rs/exec/tests/event_processor_with_json_output.rsstill construct expected results with onlycontentandstructured_content, socargo test -p codex-execwill fail to compile those tests with a missingmetafield. Please update those literals (for example withmeta: None) or otherwise make the field non-breaking for existing constructors.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The field is optional in the serialized/TS shape, but Rust struct literals still need to specify Option fields. I updated the
(1) in tests: expected McpToolCallItemResult literals with meta: None
(2) The Rust production path was already covered:
exec_events.rs (line 269) defines meta as optional and serializes it as _meta.
event_processor_with_jsonl_output.rs (line 224) already copies result.meta