Add SOCKS5 TCP MITM coverage by winston-openai · Pull Request #22685 · openai/codex

winston-openai · 2026-05-14T19:54:25Z

Summary

reuse the MITM HTTPS serving path for raw SOCKS5 TCP streams
route limited-mode and hooked SOCKS5 TCP requests through MITM before dialing upstream
keep SOCKS5 UDP limited-mode behavior unchanged

Validation

just fmt
just test -p codex-network-proxy
just fix -p codex-network-proxy
git diff --check

github-actions · 2026-05-14T19:54:42Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7d11ccc121

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

winston-openai · 2026-06-09T06:54:17Z

@codex review

chatgpt-codex-connector · 2026-06-09T06:56:49Z

Codex Review: Didn't find any major issues. 🚀

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

winston-openai · 2026-06-09T17:09:39Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8812af506c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

viyatb-oai

Looks good. Can you update codex-rs/network-proxy/README.md: it still says SOCKS5 is entirely blocked in limited mode, but this now allows HTTPS SOCKS5 TCP on :443 through MITM. The docs should say UDP and non-HTTPS TCP remain blocked, while HTTPS SOCKS5 requires MITM.

winston-openai · 2026-06-09T17:30:36Z

@codex review

winston-openai · 2026-06-09T17:30:49Z

Updated codex-rs/network-proxy/README.md in afd2f66 to document HTTPS SOCKS5 TCP on :443 requiring MITM in limited mode, with SOCKS5 UDP and non-HTTPS TCP still blocked.

chatgpt-codex-connector · 2026-06-09T17:33:18Z

Codex Review: Didn't find any major issues. Bravo.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

winston-openai force-pushed the dev/winston/credentialed-routes-refresh branch from 9b533a0 to 9d21585 Compare May 15, 2026 04:42

winston-openai force-pushed the dev/winston/socks5-tcp-mitm branch 2 times, most recently from 23cd684 to 2fcc0c6 Compare May 15, 2026 05:18

winston-openai force-pushed the dev/winston/credentialed-routes-refresh branch 2 times, most recently from 68ea51b to e0899d3 Compare May 15, 2026 12:33

winston-openai force-pushed the dev/winston/socks5-tcp-mitm branch from 2fcc0c6 to 16073ac Compare May 15, 2026 12:33

winston-openai force-pushed the dev/winston/credentialed-routes-refresh branch from e0899d3 to 9a71b42 Compare May 15, 2026 12:51

winston-openai force-pushed the dev/winston/socks5-tcp-mitm branch from 16073ac to 34d5e4d Compare May 15, 2026 12:51

winston-openai force-pushed the dev/winston/credentialed-routes-refresh branch from 9a71b42 to 91a8270 Compare May 15, 2026 17:34

winston-openai force-pushed the dev/winston/socks5-tcp-mitm branch from 34d5e4d to 74bc589 Compare May 15, 2026 17:34

winston-openai mentioned this pull request May 16, 2026

Wire MITM hooks into runtime enforcement #20659

Merged

Add SOCKS5 TCP MITM coverage

7d11ccc

winston-openai force-pushed the dev/winston/socks5-tcp-mitm branch from ee776df to 7d11ccc Compare June 9, 2026 02:52

winston-openai changed the base branch from dev/winston/credentialed-routes-refresh to main June 9, 2026 02:52

winston-openai marked this pull request as ready for review June 9, 2026 06:32

Merge branch 'main' into dev/winston/socks5-tcp-mitm

d042443

chatgpt-codex-connector Bot reviewed Jun 9, 2026

View reviewed changes

Comment thread codex-rs/network-proxy/src/socks5.rs Outdated

Restrict SOCKS5 MITM to HTTPS targets

457430a

Fix SOCKS5 MITM Bazel test race

8812af5

chatgpt-codex-connector Bot reviewed Jun 9, 2026

View reviewed changes

Comment thread codex-rs/network-proxy/src/socks5.rs

viyatb-oai approved these changes Jun 9, 2026

View reviewed changes

Document SOCKS5 MITM limited mode

afd2f66

winston-openai merged commit 472619f into main Jun 9, 2026
31 checks passed

winston-openai deleted the dev/winston/socks5-tcp-mitm branch June 9, 2026 20:08

github-actions Bot locked and limited conversation to collaborators Jun 9, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add SOCKS5 TCP MITM coverage - #22685

Add SOCKS5 TCP MITM coverage#22685
winston-openai merged 5 commits into
mainfrom
dev/winston/socks5-tcp-mitm

winston-openai commented May 14, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 14, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

winston-openai commented Jun 9, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 9, 2026

Uh oh!

winston-openai commented Jun 9, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

viyatb-oai left a comment •

edited

Loading

Uh oh!

winston-openai commented Jun 9, 2026

Uh oh!

winston-openai commented Jun 9, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

winston-openai commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Validation

Uh oh!

github-actions Bot commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

winston-openai commented Jun 9, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 9, 2026

Uh oh!

winston-openai commented Jun 9, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

viyatb-oai left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

winston-openai commented Jun 9, 2026

Uh oh!

winston-openai commented Jun 9, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

winston-openai commented May 14, 2026 •

edited

Loading

github-actions Bot commented May 14, 2026 •

edited

Loading

viyatb-oai left a comment •

edited

Loading