-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[codex] Honor role-defined spawn service tiers #22169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
bb17946
Add spawn agent service tier overrides
aibrahim-oai 7efdaae
Tighten spawn agent service tier guidance
aibrahim-oai 62f7566
Honor role-defined spawn service tiers
aibrahim-oai 6cd2781
codex: fix CI failure on PR #22169
aibrahim-oai 04a51a3
Simplify role service tier flow
aibrahim-oai 9b0fc86
Match role service tier precedence
aibrahim-oai a33758b
Cover v2 role service tier precedence
aibrahim-oai 371e5b5
codex: resolve agent role service tier review
aibrahim-oai 2d64b20
codex: fix service tier fallback borrow
aibrahim-oai 3223b8d
Clarify role service tier guidance
aibrahim-oai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This only checks for a top-level
service_tier, but role files can select or define profiles, andConfigProfilehas its ownservice_tier;Config::load_config_with_layer_stackonly readsconfig_profile.service_tierwhen the service-tier override isNone. With a role such asprofile = "tiered"plus[profiles.tiered] service_tier = "priority"(or a role update to the active profile), this line preserves the parent/request tier as an override, so the profile-defined role tier is ignored instead of being honored.Useful? React with 👍 / 👎.