Update models.json - #21818
Conversation
b8173bb to
e2f6d62
Compare
2cfa333 to
e1fd519
Compare
49ab0d7 to
1dbd4ef
Compare
4918ab2 to
a4789c5
Compare
sayan-oai
left a comment
There was a problem hiding this comment.
actually we cant rm 5.2 while some residencies still use it. will look at this later, will require a larger change
sayan-oai
left a comment
There was a problem hiding this comment.
lgtm in that it no longer drops 5.2
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 19e9a23869
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "model": "gpt-5.4", | ||
| "migration_markdown": "Introducing GPT-5.4\n\nCodex just got an upgrade with GPT-5.4, our most capable model for professional work. It outperforms prior models while being more token efficient, with notable improvements on long-running tasks, tool calling, computer use, and frontend development.\n\nLearn more: https://openai.com/index/introducing-gpt-5-4\n\nYou can always keep using GPT-5.3-Codex if you prefer.\n" | ||
| "model": "gpt-5.5", | ||
| "migration_markdown": "Introducing GPT-5.5\n\nGPT-5.5 is now available in Codex. It's our strongest agentic coding model yet, built to reason through large codebases, check assumptions with tools, and keep going until the work is done.\n\nLearn more: https://openai.com/index/introducing-gpt-5-5/\n\nYou can always keep using GPT-5.4 if you prefer.\n" |
There was a problem hiding this comment.
When the current model is gpt-5.2, startup_prompts.rs reads this entry and passes migration_markdown directly into the model migration prompt, so affected users will be told “You can always keep using GPT-5.4” even though the model they are opting out to keep is GPT-5.2. This stale fallback sentence makes the upgrade prompt misleading; it should name GPT-5.2 for this entry, and the user-visible text change should have snapshot coverage.
AGENTS.md reference: AGENTS.md:L180-L187
Useful? React with 👍 / 👎.
| }, | ||
| { | ||
| "slug": "gpt-5.2", |
There was a problem hiding this comment.
Existing users who still have model = "gpt-5.3-codex" rely on the hidden catalog entry's upgrade metadata: startup_prompts.rs first looks up the current model in available_models, so once this commit removes that entry, those users no longer get prompted to move to a supported model and instead continue with fallback unknown-model metadata. Keep a hidden gpt-5.3-codex entry with the new upgrade target, or add equivalent migration handling before dropping the slug.
AGENTS.md reference: AGENTS.md:L102-L110
Useful? React with 👍 / 👎.
Automated update of models.json.