Add compact lifecycle hooks (started by vincentkoc - external contrib)#19905
Merged
eternal-openai merged 20 commits intomainfrom May 7, 2026
Merged
Add compact lifecycle hooks (started by vincentkoc - external contrib)#19905eternal-openai merged 20 commits intomainfrom
eternal-openai merged 20 commits intomainfrom
Conversation
This was referenced Apr 28, 2026
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f050381923
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ks-lifecycle # Conflicts: # codex-rs/hooks/src/lib.rs
…ks-lifecycle # Conflicts: # codex-rs/hooks/src/lib.rs # codex-rs/hooks/src/registry.rs
This was referenced Apr 30, 2026
pakrym-oai
reviewed
Apr 30, 2026
| Stopped, | ||
| } | ||
|
|
||
| pub(crate) async fn run_post_compact_hooks( |
Collaborator
There was a problem hiding this comment.
very non blocking nit: these methods look very boilerplate (most of request parameters are repeated, event emmiting, etc.)
…ks-lifecycle # Conflicts: # codex-rs/app-server/src/config_api.rs # codex-rs/core/config.schema.json # codex-rs/core/src/session/turn.rs # codex-rs/tui/src/chatwidget/tests/helpers.rs
…ks-lifecycle # Conflicts: # codex-rs/hooks/src/engine/mod.rs
pakrym-oai
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on work from Vincent K - #19060
Why
Compaction rewrites the conversation context that future model turns receive, but hooks currently have no deterministic lifecycle point around that rewrite. This adds compact lifecycle hooks so users can audit manual and automatic compaction, surface hook messages in the UI, and run post-compaction follow-up without overloading tool or prompt hooks.
What Changed
PreCompactandPostCompacthook events across hook config, discovery, dispatch, generated schemas, app-server notifications, analytics, and TUI hook rendering.manualandautomatcher values.PreCompactbefore both local and remote compaction, andPostCompactafter successful local or remote compaction.decision:"block"does not block compaction.Out of Scope
decision:"block"and exit-code-2 blocking semantics are intentionally unsupported forPreCompact.Verification
cargo test -p codex-hookscargo test -p codex-core manual_pre_compact_block_decision_does_not_block_compactioncargo test -p codex-app-server hooks_listcargo test -p codex-core config_schema_matches_fixturecargo test -p codex-tui hooks_browserDocs
The developer documentation for Codex hooks should be updated alongside this feature to document
PreCompactandPostCompact, themanual/automatcher values, and the compact hook payload fields.