Skip to content

fix: allow completion when no draft manifest exists yet (#73) #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mldangelo-oai merged 2 commits into from
Jul 31, 2026
Merged

fix: allow completion when no draft manifest exists yet (#73) #83

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7db1464
fix: allow completion when no draft manifest exists yet
onurtirpan Jul 29, 2026
014da48
Merge branch 'main' into fix/scan-manifest-required-on-fresh-scan
onurtirpan Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions sdk/typescript/_bundled_plugin/scripts/workbench_db.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1420,11 +1420,18 @@ def complete_scan_locked(
completion_timestamp = now()
completion_binding = workbench_completion_binding(scan, completion_timestamp)
if scan["recipe_json"] is not None:
manifest = read_json_object(artifact_path(scan_dir, ARTIFACTS["manifest"], required=True))
manifest_scan = manifest.get("scan")
if isinstance(manifest_scan, dict) and manifest_scan.get("sealedAt") is not None:
completion_binding["startedAt"] = manifest_scan.get("startedAt")
completion_binding["completedAt"] = manifest_scan.get("completedAt")
# Fresh recipe-driven scans have no prior scan-manifest.json on disk — the
# draft is authored later by _write_prepared_scan_finalization. Guard the
# read so first-time completion does not fail with "expected a regular
# file inside the scan directory" (issue #73). When a prior manifest does
# exist (resumed / re-completed scans), preserve the sealed timestamps.
manifest_path = artifact_path(scan_dir, ARTIFACTS["manifest"], required=False)
if manifest_path is not None:
manifest = read_json_object(manifest_path)
manifest_scan = manifest.get("scan")
if isinstance(manifest_scan, dict) and manifest_scan.get("sealedAt") is not None:
completion_binding["startedAt"] = manifest_scan.get("startedAt")
completion_binding["completedAt"] = manifest_scan.get("completedAt")
try:
prepared = _prepare_scan_finalization(
scan_dir,
Expand Down
Loading