fix: settle login close when children ignore SIGTERM or hold pipes - #142
Closed
mangeshraut712 wants to merge 1 commit into
Closed
fix: settle login close when children ignore SIGTERM or hold pipes#142mangeshraut712 wants to merge 1 commit into
mangeshraut712 wants to merge 1 commit into
Conversation
|
Note You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
CodexLoginHandle waited only on child "close", which hung when the process ignored SIGTERM or kept stdio pipes open. Add a cross-platform exit-then-destroy-stdio fallback and escalate cancel with SIGKILL after SIGTERM so CI login teardown cannot stall indefinitely. Addresses #131
mangeshraut712
force-pushed
the
fix/login-close-hang-ci
branch
from
July 30, 2026 17:21
04bacf2 to
5ab7dca
Compare
Collaborator
|
Thank you for looking into login processes that do not exit cleanly. The shutdown fix has already landed on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
node-cihang onmainwhereCodexSecurity orchestration > keeps ambient credentials available after successful ChatGPT logintimed out and left orphanedbun/nodeprocesses (example).SIGTERM, escalate toSIGKILLand destroy stdio sologin.wait()/close()always settle.actions/checkout→ v7.0.1,actions/setup-node→ v7.0.0.Test plan
bun test ./tests-ts/auth.test.ts(includes new SIGTERM-ignore + cross-platform pipe fallback)bun test ./tests-ts/cli.test.tsnode-ci/container-cion this PR