fix: keep scan output dirs private across shared parents - #110
Closed
batmnnn wants to merge 1 commit into
Closed
Conversation
Reject group/world-writable non-sticky output parents at prepare time, and re-check scan-directory ownership/mode whenever the workbench or contract loader resolves the path, so a mid-scan rename under a shared parent cannot substitute forged completion artifacts. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
@mldangelo should I close this ? |
Collaborator
|
Thanks for working on output-directory privacy. A stronger version of the same protection has already landed on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
bun test --timeout 60000 ./tests-ts/runtime.test.ts ./tests-ts/contract.test.ts ./tests-ts/api.test.ts(129 pass)node-cipasses on this branchMade with Cursor