Add Optional based on variantSrc::variant#806
Merged
Conversation
ax3l
reviewed
Oct 28, 2020
ax3l
reviewed
Oct 28, 2020
ax3l
left a comment
Member
There was a problem hiding this comment.
LGTM. Minor points added as comments.
Can you please add test coverage for openPMD::auxiliary::Option in test/AuxiliaryTest.cpp?
ax3l
approved these changes
Oct 28, 2020
ax3l
reviewed
Oct 28, 2020
|
|
||
| Option<int> opt; | ||
|
|
||
| REQUIRE_THROWS(opt.get()); |
Member
There was a problem hiding this comment.
This line calls std::terminate() while throwing mpark::throw_bad_variant_access in GCC 4.8 and 4.9.
For some reason, MPARK_EXCEPTIONS is not defined for this:
Member
There was a problem hiding this comment.
PR: mpark/variant#76
Will push a work-around here and unify the variant include, to avoid potential ODR issues.
Add unit tests for `auxiliary::Option`
Enable exceptions with older GCC. See upstream PR for release 1.4.0.
c6d486f to
1e51f7d
Compare
ax3l
approved these changes
Oct 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a class template
openPMD::auxiliary::Optionto provide for somewhat the same functionality as C++17'sstd::optionaland uses it in several places in the ADIOS2 backend. Close #563.