setup.py: Windows openPMD_CMAKE_... Env Vars#1896
Open
ax3l wants to merge 2 commits into
Open
Conversation
We pass openPMD_CMAKE_<CMakeVar>=<value> environment variables through as `-D` flags to CMake configure. Windows environment variable are all CAPS, so also accept the all-caps variant of the prefix, then the `openPMD_` CMake option names are case-sensitive, so restore the "openPMD_" prefix that upper-casing would destroy. All suffixes of our options are luckily `..._ALL_CAPS` anyway.
ax3l
commented
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We pass
openPMD_CMAKE_<CMakeVar>=<value>environment variables through as-Dflags to CMake configure.Windows environment variable are all CAPS, so also accept the all-caps variant of the prefix, then the
openPMD_CMake option names are case-sensitive,so restore the
openPMD_...prefix that upper-casing would destroy. All suffixes of our options areluckily
..._ALL_CAPSanyway.Noticed in #1892 that our
openPMD_CMAKE_openPMD_USE_ADIOS2='ON'env var was ignored on Windows, defaulting toAUTO, which skipped ADIOS2 since we had a transitive dependency issue.