CMake HDF5 Static: Work-Around for ZLIB#1894
Merged
Merged
Conversation
ZLIB (work-around for an upstream HDF5 packaging issue) Static build of HDF5 forget to do `find_dependency(ZLIB) in their CMake config, but expose them in INTERFACE_LINK_LIBRARIES. Thus, `find_package(HDF5)` fails. ZLIB is optional but usually used by HDF5.
ax3l
added a commit
to ax3l/openPMD-api
that referenced
this pull request
Jun 23, 2026
Replace the local patch files with the exact diffs from the openPMD-api dev PRs (openPMD#1893 FindPython cross-compile, openPMD#1894 HDF5 ZLIB::ZLIB workaround), so the wheel CI builds and runtime-tests precisely the code that will land in dev. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZLIB (work-around for an upstream HDF5 packaging issue) Static build of HDF5 forget to do
find_dependency(ZLIB) in their CMake config, but expose them in INTERFACE_LINK_LIBRARIES. Thus,find_package(HDF5)` fails. ZLIB is optional but usually used by HDF5.Needed for #1892