Skip to content

Fix deprecated use in InvalidatableFile.hpp#1888

Merged
ax3l merged 1 commit into
openPMD:devfrom
dpgrote:fix_InvalidatableFile_deprecated
Jun 22, 2026
Merged

Fix deprecated use in InvalidatableFile.hpp#1888
ax3l merged 1 commit into
openPMD:devfrom
dpgrote:fix_InvalidatableFile_deprecated

Conversation

@dpgrote

@dpgrote dpgrote commented Jun 22, 2026

Copy link
Copy Markdown
Member

The use of std::less<std::string>::result_type was deprecated in C++17, removed in C++20 (already on Apple's stdlib). The recommended fix is to use bool.
https://en.cppreference.com/cpp/utility/functional/less

@ax3l ax3l requested review from ax3l and franzpoeschel June 22, 2026 20:43
@ax3l ax3l self-assigned this Jun 22, 2026
@ax3l ax3l added this to the 0.17.1 milestone Jun 22, 2026

@ax3l ax3l left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! Will port to 0.17.1 #1880

@ax3l ax3l merged commit e167bfb into openPMD:dev Jun 22, 2026
30 of 31 checks passed
@dpgrote dpgrote deleted the fix_InvalidatableFile_deprecated branch June 22, 2026 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants