fix(i18n): replace hardcoded english strings with translate pipes in …#3319
fix(i18n): replace hardcoded english strings with translate pipes in …#3319NotxNoodles wants to merge 1 commit intoopenMF:devfrom
Conversation
|
Note
|
| Cohort / File(s) | Summary |
|---|---|
Receipt View Component Template src/app/savings/savings-account-view/transactions/view-reciept/view-reciept.component.html |
Replaced hard-coded UI strings with i18n translation keys for back button label, NoData block heading, list items, and informational messages. |
Translation File src/assets/translations/en-US.json |
Added seven new translation entries for receipt view error messages and informational text (Unable to Load Receipt, Invalid transaction data, Missing or incomplete report configuration, Report generation service unavailable, Please contact your system administrator for assistance, Technical details may be available in the browser console, and The transaction receipt could not be loaded message). |
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
Suggested reviewers
- IOhacker
- alberto-art3ch
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The PR title accurately describes the primary change: replacing hardcoded English strings with translate pipes for i18n support in the view-receipt component. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Post copyable unit tests in a comment
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
alberto-art3ch
left a comment
There was a problem hiding this comment.
Please add the translation in the other languages
Description
Replaced 7 hardcoded English strings in the
view-reciept.component.htmltemplate withtranslatepipes to fully support internationalization (i18n).Changes Made:
view-reciept.component.html: Replaced the hardcoded "Back" button with the existinglabels.buttons.Backkey. Replaced the 6 hardcoded error strings in the<ng-template #noData>block with translation keys.en-US.json: Safely added the 7 new translation keys to ensure the error block renders correctly in English:labels.heading.Unable to Load Receiptlabels.text.Invalid transaction datalabels.text.Missing or incomplete report configurationlabels.text.Please contact your system administrator for assistance.labels.text.Report generation service unavailablelabels.text.Technical details may be available in the browser console (F12).labels.text.The transaction receipt could not be loaded. This may be due to:Note: Part of my familiarization with the Angular codebase for GSoC 2026 (MCP AI Assistant).
Related issues and discussion
N/A - Minor i18n cleanup spotted during codebase review.
Screenshots, if any
N/A
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
web-app/.github/CONTRIBUTING.md.Summary by CodeRabbit