Skip to content

Wrong test value for default timeout in OTLP Exporter Mixin #4057

@ocelotl

Description

@ocelotl
          Either I don't understand the change or there is a new bug here. How can it be correct to change `start_time` and `now` from seconds to nanoseconds without changing the `30 / 1000`?

Secondly, does anyone understand what this assert is supposed to do? I understand it somehow like: "Ensure that the shutdown took at least 30 seconds.". If this is the case, shouldn't it be 30 * 1000 then originally and now `30 * 1e9?

Originally posted by @LarsMichelsen in #4014 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions