[exporter/stef] Fix connection creation bug causing test failures #44048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@tigrannajaryan please add a changelog entry in .chloggen |
dmitryax
approved these changes
Nov 4, 2025
Fixes open-telemetry#42947 TestHarness_MetricsGoldenData/stef-stef was sporadically failing because of a bug in the implementation of Create() function. Just created connection could have been closed because of the bug, depending on the order of "select" operations and the timing of other operations. This now fixes the bug, ensuring the code does not try to cancel a successfully created connection. I managed to create a simple repro by adding a time delay in the inner goroutine, but I won't be commiting the change since it is detrimental to production code. There is no trivial way to add a reliable test that verifies specifically this bug, but TestHarness_MetricsGoldenData/stef-stef was already hitting it once in a while, so we will rely on that as the test that verifies the bug fix.
5dbe5c0 to
ef3aabd
Compare
Member
Author
Added. |
jelly-afk
pushed a commit
to jelly-afk/opentelemetry-collector-contrib
that referenced
this pull request
Nov 6, 2025
…en-telemetry#44048) Fixes open-telemetry#42947 TestHarness_MetricsGoldenData/stef-stef was sporadically failing because of a bug in the implementation of Create() function. Just created connection could have been closed because of the bug, depending on the order of "select" operations and the timing of other operations. This now fixes the bug, ensuring the code does not try to cancel a successfully created connection. I managed to create a simple repro by adding a time delay in the inner goroutine, but I won't be commiting the change since it is detrimental to production code. There is no trivial way to add a reliable test that verifies specifically this bug, but TestHarness_MetricsGoldenData/stef-stef was already hitting it once in a while, so we will rely on that as the test that verifies the bug fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42947
TestHarness_MetricsGoldenData/stef-stef was sporadically failing because of a bug in the implementation of Create() function. Just created connection could have been closed because of the bug, depending on the order of "select" operations and the timing of other operations.
This now fixes the bug, ensuring the code does not try to cancel a successfully created connection.
I managed to create a simple repro by adding a time delay in the inner goroutine, but I won't be commiting the change since it is detrimental to production code. There is no trivial way to add a reliable test that verifies specifically this bug, but TestHarness_MetricsGoldenData/stef-stef was already hitting it once in a while, so we will rely on that as the test that verifies the bug fix.