[cmd/opampsupervisor] Redact HTTP headers in debug message #43781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iblancasa
approved these changes
Oct 28, 2025
TylerHelmuth
approved these changes
Nov 4, 2025
Member
|
Please add a changelong |
jelly-afk
pushed a commit
to jelly-afk/opentelemetry-collector-contrib
that referenced
this pull request
Nov 6, 2025
…metry#43781) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Redacts the user-provided HTTP header values when writing them in a debug message on OpAMP server startup. If using the following example config: ```yaml server: endpoint: "http://127.0.0.1:8080/v1/opamp" headers: Authorization: "Basic dXNlcjpwd2QK" agent: executable: ./bin/otelcol-contrib telemetry: logs: level: debug ``` The log output will now look like: ``` {"level":"debug","ts":1761474887.360533,"logger":"supervisor","caller":"supervisor/supervisor.go:663","msg":"Connecting to OpAMP server...","endpoint":"http://127.0.0.1:8080/v1/opamp","headers":{"Authorization":["[REDACTED]"]}} ``` <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#43780 <!--Describe what testing was performed and which tests were added.--> #### Testing Added unit tests for `OpAMPServer.OpaqueHeaders()` method. <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Redacts the user-provided HTTP header values when writing them in a debug message on OpAMP server startup.
If using the following example config:
The log output will now look like:
Link to tracking issue
Fixes #43780
Testing
Added unit tests for
OpAMPServer.OpaqueHeaders()method.Documentation