Allow service.namespace to be used in rules and fix docs #40859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6c38397 to
abd3f43
Compare
Signed-off-by: ChrsMark <[email protected]>
abd3f43 to
5808818
Compare
florianl
approved these changes
Jun 23, 2025
zeitlinger
approved these changes
Jun 24, 2025
Contributor
|
need a codeowner review from @dmitryax, @fatsheep9146, @TylerHelmuth |
MovieStoreGuy
approved these changes
Jul 29, 2025
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Member
|
need a codeowner review from @dmitryax, @fatsheep9146, @TylerHelmuth |
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
dmitryax
approved these changes
Aug 29, 2025
Member
|
thanks for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a follow up from #40745 to:
container.idcan be used in rulesservice.instance.idcannot be used in rulesservice.versioncannot be used in rules when it's calculated based on container's imageservice.namespaceto be used in rulesTesting
Documentation
Fixed
/cc @florianl @dmitryax @zeitlinger