Open
Conversation
sid42
reviewed
Mar 16, 2026
Comment on lines
+1118
to
+1129
| if assetsReceived == nil || assetsReceived! == 0 { | ||
| self._recoverSharesToAutoBalancer(yieldVaultID: yieldVaultID, info: info) | ||
| handler.setClaimOutcome(yieldVaultID: yieldVaultID, outcome: "failed") | ||
| emit RedeemRecovered( | ||
| yieldVaultID: yieldVaultID, | ||
| userAddress: info.userFlowAddress, | ||
| vaultEVMAddressHex: info.vaultEVMAddress.toString() | ||
| ) | ||
| handler.removePendingRedeem(id: yieldVaultID) | ||
| handler.removeScheduledTx(id: yieldVaultID) | ||
| return | ||
| } |
Collaborator
There was a problem hiding this comment.
It would nice to be able to differentiate between when the assetsReceived == nil and the assetsReceived! == 0 error, right now either error will go into the same code path and emit the same event.
Maybe this could be added to the RedeemRecovered event
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
claimRedeempermissionless with a timelock guard (intended to address comment). When EVMredeemreverts, shares are recovered back to the user inAutoBalancerFollow-up to #210
Description
For contributor use:
masterbranchFiles changedin the Github PR explorer