Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ユーザーは
.identity(...)か.coding(...)を使って構築します。codingにおいてはjsonTypeは必須に変わりました。自動で用意される
Foo_JSON型が自明でなくてあまり嬉しくないため。Dateのテストケースは、
jsonTypeとしてstringを使うように書き換えました。enumでの実装も検討しました。#47
associated valueを抽出するところで、
_を並べないといけなくて、associated valueが増えたら全箇所修正が必要なところがしっくり来ないのでやめました。
computed propertyを定義しない場合は、
利用側のTypeMapConverterで直接分岐する場合、
同じ分岐を重複して出てしまうのが微妙でした。