Merged
Conversation
sidepelican
reviewed
Dec 3, 2022
| S: never; | ||
| }; | ||
| """, """ | ||
| export type S_JSON = E_JSON & { |
Collaborator
There was a problem hiding this comment.
ここは変に感じました。
JSON型は実際にSwiftとTS間でやりとりされるjsonの構造を忠実に表したものだと思っていて、そこにはarray, object, null, number, stringのようなjsonの基本型以外のものは現れないと思いました。
型付けはEntity型に変化する際に行われる(enumはそう)ので、Phantom Typeの型付けもEntity型への変換タイミングで行うべきに思いました。
This was referenced Dec 4, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#40 の対応
Swift側の型情報をなるべくTypeScriptで再現するため、phantom typeの生成を導入した。
判定は
rawValueプロパティを見ているだけのガバガバ実装。