StrictConcurrencyを有効にする、Sendableを付ける #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omochi
commented
Apr 12, 2024
| extension TSIdentExpr { | ||
| static let json = TSIdentExpr("json") | ||
| static let entity = TSIdentExpr("entity") | ||
| static var json: TSIdentExpr { TSIdentExpr("json") } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C2TSを利用するアプリケーションのビルド時に、
一部でSendable警告が出てしまうので対応する
TSASTはミュータブルなASTなのでSendableにならない。
Generator関係は抽象化が複雑でできるかわからないのでやらなかった。
これ以外で、C2TSで導入されるvalue semanticなものはSendableにした。
TypeMapのMapFunctionがSendableになったのは、
厳密には下位互換を破壊する。
しかし、利用する場面ではそこまでダイナミックな処理に接続しているとは考えにくくて、
多少複雑な判定をする程度で対応できると思う。