Skip to content

Conversation

@akshay-ap
Copy link
Contributor

Fixes #1111

Changes proposed in this PR:

  • Make headers bold in fees page

| consumeMarket: FixedRate<br>EnterpriseTemplate | 0% | Set in market config, by the consuming market. |
| Ocean Community: FixedRate<br>OCEAN, H2O as base token | 0.1% | 0.1% |
| Ocean Community: FixedRate<br>other base token | 0.2% | 0.2% |
| <b>Publish Fees</b> | 0% | 0% |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really get why Publish Fees and Order Fees are in bold?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Split the 2 tables in 4 tables.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akshay-ap are you still working on this or do you want me to take it over?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit ccefabe and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, looks good

@jamiehewitt15 jamiehewitt15 merged commit 331b10d into main Sep 26, 2022
@jamiehewitt15 jamiehewitt15 deleted the issue-1111-fees-page-emphasize-table-headers branch September 26, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make table headers bold in fees page

3 participants