-
Notifications
You must be signed in to change notification settings - Fork 40
Make headers bold in fees page #1112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make headers bold in fees page #1112
Conversation
core-concepts/fees.md
Outdated
| | consumeMarket: FixedRate<br>EnterpriseTemplate | 0% | Set in market config, by the consuming market. | | ||
| | Ocean Community: FixedRate<br>OCEAN, H2O as base token | 0.1% | 0.1% | | ||
| | Ocean Community: FixedRate<br>other base token | 0.2% | 0.2% | | ||
| | <b>Publish Fees</b> | 0% | 0% | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really get why Publish Fees and Order Fees are in bold?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Split the 2 tables in 4 tables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akshay-ap are you still working on this or do you want me to take it over?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Code Climate has analyzed commit ccefabe and detected 0 issues on this pull request. View more on Code Climate. |
jamiehewitt15
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, looks good
Fixes #1111
Changes proposed in this PR: