-
Notifications
You must be signed in to change notification settings - Fork 40
Subgraph examples #1085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subgraph examples #1085
Conversation
👷 Deploy Preview for docs-oceanprotocol processing.
|
jamiehewitt15
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good. As well as showing how to run the query with a python script, can you also explain that the queries can as be done in the graphiQL interface. Also, another possible extension would be to also have a tab showing the JS version of the python script but that's not essential
added GraphQL UI hint in each page. Can we add JS version later? |
This is good thanks
Yeah that's reasonably low priority / nice-to-have. I create an issue to ensure we don't lose track of it. Something else that I've noticed here is that the opening page on the sub-graph is too short. We should put a bit more info in here which can largely be copied from the readme, how to run it locally etc... |
jamiehewitt15
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The examples are really good. Any other improvements, as mentioned above can be handled in another PR
Fixes #797
Add Ocean subgraph examples
Changes proposed in this PR: