Skip to content

Conversation

@akshay-ap
Copy link
Contributor

Fixes #797

Add Ocean subgraph examples

Changes proposed in this PR:

  • List data NFTs
  • List all tokens
  • Get data NFT information
  • Get datatoken information
  • Get Fixed Rate Exchanges

@akshay-ap akshay-ap self-assigned this Jul 31, 2022
@netlify
Copy link

netlify bot commented Jul 31, 2022

👷 Deploy Preview for docs-oceanprotocol processing.

Name Link
🔨 Latest commit b59abeb
🔍 Latest deploy log https://app.netlify.com/sites/docs-oceanprotocol/deploys/62e7d4b1fa264e0008d28372

Copy link
Contributor

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good. As well as showing how to run the query with a python script, can you also explain that the queries can as be done in the graphiQL interface. Also, another possible extension would be to also have a tab showing the JS version of the python script but that's not essential

@akshay-ap
Copy link
Contributor Author

This is good. As well as showing how to run the query with a python script, can you also explain that the queries can as be done in the graphiQL interface. Also, another possible extension would be to also have a tab showing the JS version of the python script but that's not essential

added GraphQL UI hint in each page.

Can we add JS version later?

@akshay-ap akshay-ap requested a review from jamiehewitt15 August 1, 2022 15:06
@jamiehewitt15
Copy link
Contributor

added GraphQL UI hint in each page.

This is good thanks

Can we add JS version later?

Yeah that's reasonably low priority / nice-to-have. I create an issue to ensure we don't lose track of it.

Something else that I've noticed here is that the opening page on the sub-graph is too short. We should put a bit more info in here which can largely be copied from the readme, how to run it locally etc...

Copy link
Contributor

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The examples are really good. Any other improvements, as mentioned above can be handled in another PR

@jamiehewitt15 jamiehewitt15 merged commit 3c32812 into main Aug 2, 2022
@jamiehewitt15 jamiehewitt15 deleted the issue-797-subgraph-examples branch August 2, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document query examples for aquarius/subgraph

3 participants