fix(melange): revert default sandboxing - #15418
Merged
anmonteiro merged 1 commit intoJul 4, 2026
Merged
Conversation
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
anmonteiro
force-pushed
the
anmonteiro/melange-revert-sandboxing
branch
from
July 4, 2026 21:02
b23ce34 to
0e9c0cf
Compare
anmonteiro
added a commit
to anmonteiro/dune
that referenced
this pull request
Jul 20, 2026
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
anmonteiro
added a commit
that referenced
this pull request
Jul 20, 2026
avsm
pushed a commit
to ocaml/opam-repository
that referenced
this pull request
Jul 23, 2026
CHANGES: ### Fixed - Fix an internal error (`modules_and_obj_dir: failed lookup`) when generating `js_of_ocaml` archive rules for a dune file that defines two libraries with the same name distinguished by mutually exclusive `enabled_if` clauses, as `ocaml-re` does for `ppx_expect_common` (ocaml/dune#14904, fixes ocaml/dune#14775, @vouillon) - Fix passing environment variables to formatter actions (ocaml/dune#15386, @anmonteiro) - Fix missing source dependency in the sandbox when preprocessing Melange sources (ocaml/dune#15395, @anmonteiro) - Treat OCaml compiler packages version 5.5 or newer as relocatable so their installations do not use the toolchain cache (ocaml/dune#15444, fixes ocaml/dune#15443, @Alizter) - Fix `build_runtime_flags` given in a `js_of_ocaml`/`wasm_of_ocaml` field of an executable being silently ignored in separate compilation mode: such executables were given the workspace-shared standalone runtime, which is built with the default flags. Executables customizing `build_runtime_flags` now get their own standalone runtime again. (ocaml/dune#15455, @hhugo) - Use installed filenames for local package binaries in `%{bin:...}` PATH layouts on Windows (ocaml/dune#15518, fixes ocaml/dune#15512, @Alizter) ### Changed - Revert sandboxing Melange rules by default in the `(library ..)` and `(melange.emit ..)` stanzas. In Melange libraries with many modules, sandbox creation / destruction dominates build time and adds significant overhead to build time (ocaml/dune#15418, @anmonteiro)
craff
pushed a commit
to craff/opam-repository
that referenced
this pull request
Jul 25, 2026
CHANGES: ### Fixed - Fix an internal error (`modules_and_obj_dir: failed lookup`) when generating `js_of_ocaml` archive rules for a dune file that defines two libraries with the same name distinguished by mutually exclusive `enabled_if` clauses, as `ocaml-re` does for `ppx_expect_common` (ocaml/dune#14904, fixes ocaml/dune#14775, @vouillon) - Fix passing environment variables to formatter actions (ocaml/dune#15386, @anmonteiro) - Fix missing source dependency in the sandbox when preprocessing Melange sources (ocaml/dune#15395, @anmonteiro) - Treat OCaml compiler packages version 5.5 or newer as relocatable so their installations do not use the toolchain cache (ocaml/dune#15444, fixes ocaml/dune#15443, @Alizter) - Fix `build_runtime_flags` given in a `js_of_ocaml`/`wasm_of_ocaml` field of an executable being silently ignored in separate compilation mode: such executables were given the workspace-shared standalone runtime, which is built with the default flags. Executables customizing `build_runtime_flags` now get their own standalone runtime again. (ocaml/dune#15455, @hhugo) - Use installed filenames for local package binaries in `%{bin:...}` PATH layouts on Windows (ocaml/dune#15518, fixes ocaml/dune#15512, @Alizter) ### Changed - Revert sandboxing Melange rules by default in the `(library ..)` and `(melange.emit ..)` stanzas. In Melange libraries with many modules, sandbox creation / destruction dominates build time and adds significant overhead to build time (ocaml/dune#15418, @anmonteiro)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.