test(clean): demonstrate that clean rejects source directories (#2288) - #15300
Merged
Conversation
Document the limitation from #2288: unlike `dune build`, `dune clean` does not accept a source directory (or package name) — it only accepts paths inside the build directory. `dune build sub` works, but `dune clean sub` and `dune clean .` fail with "<path> is not inside the build directory". This pins the current behaviour; the expected output will flip once `dune clean` learns to accept source directories. Signed-off-by: Rudi Grinberg <me@rgrinberg.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Alizter
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduces #2288:
dune cleandoes not accept source directories (or packagenames) the way
dune build/dune runtestdo — it only accepts paths insidethe build directory (a capability added in #13875).
This adds a test to
clean.tdocumenting the current behaviour:dune build subaccepts the source directorydune clean subfails withError: sub is not inside the build directorydune clean .fails likewiseNo behaviour change — the test pins the status quo so it will flip to the
desired output if/when
dune cleanlearns to accept source directories.🤖 Generated with Claude Code