Skip to content
This repository was archived by the owner on Jul 31, 2025. It is now read-only.

Fix templates that generate incorrect labels#71

Closed
rays22 wants to merge 1 commit into
masterfrom
upheno-issue983
Closed

Fix templates that generate incorrect labels#71
rays22 wants to merge 1 commit into
masterfrom
upheno-issue983

Conversation

@rays22

@rays22 rays22 commented Jul 23, 2025

Copy link
Copy Markdown
Collaborator

Fix templates that generate incorrect labels that start with "formed" instead of the correct "malformed".

If applied, this commit will fix obophenotype/upheno#983 .

Fix templates that generate incorrect labels that start with "formed" instead of the correct "malformed".

If applied, this commit will fix obophenotype/upheno#983 .
@rays22 rays22 self-assigned this Jul 23, 2025
@rays22

rays22 commented Jul 23, 2025

Copy link
Copy Markdown
Collaborator Author

The QC job failed because the file imports/merged_import.owl could not be found:

imports/merged_import.owl (No such file or directory)
make: *** [upheno.Makefile:166: tmp/upheno-preprocess.owl] Error 1

@rays22
rays22 requested a review from matentzn July 23, 2025 16:26
@matentzn

Copy link
Copy Markdown
Contributor

@rays22 can you open this PR on the uPheno repo? This repo here is not suitable as I will close it soon.. uPheno is the source of truth!

@rays22

rays22 commented Jul 30, 2025

Copy link
Copy Markdown
Collaborator Author

@rays22 can you open this PR on the uPheno repo? This repo here is not suitable as I will close it soon.. uPheno is the source of truth!

OK, the pattern files dosdp-patterns/malformedAnatomicalEntity.yaml and malformedAnatomicalEntityInLocation.yaml in in the upheno repo look fine. In contrast, these two files in upheno-dev look like the sources of the incorrect text: formed %s labels mentioned in obophenotype/upheno#983.
Probably I don’t understand how upheno http://purl.obolibrary.org/obo/upheno/releases/2025-07-21/upheno.owl that is being displayed on OLS have been created.

@matentzn

Copy link
Copy Markdown
Contributor

Thanks for bringing it up, I will solve this differently!

@matentzn matentzn closed this Jul 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

incorrect label

2 participants