Allow BindStyledParameterWithOptions to fill maps#72
Merged
mromaszewicz merged 1 commit intooapi-codegen:mainfrom Oct 30, 2025
Merged
Allow BindStyledParameterWithOptions to fill maps#72mromaszewicz merged 1 commit intooapi-codegen:mainfrom
mromaszewicz merged 1 commit intooapi-codegen:mainfrom
Conversation
mromaszewicz
approved these changes
Oct 30, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our API we have something like:
If the X-Metadata header is defined with e.g. "foo,bar" I always get the error:
Invalid format for parameter X-Metadata: error binding string parameter: can not bind to destination of type: map.The issue is that the X-Metadata type is a map[string]string which is not handled by
BindStyledParameterWithOptions.I extended the function to use the same code path for reflect.Map as for reflect.Struct