Skip to content

fix: arithmetic on nil value error on first git project open #3064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alex-courtis merged 3 commits into from
Feb 9, 2025
Merged

fix: arithmetic on nil value error on first git project open #3064

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e9df34f
fixed error message when opening new git repo
bafto Feb 2, 2025
13f7206
defensive nil + type check
bafto Feb 3, 2025
15c8615
Merge branch 'master' into nil-arithmetic-fix
alex-courtis Feb 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lua/nvim-tree/explorer/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,9 +389,9 @@ function Explorer:populate_children(handle, cwd, node, project, parent)
nodes_by_path[child.absolute_path] = true
child:update_git_status(node_ignored, project)
end
else
elseif node.hidden_stats then
for reason, value in pairs(FILTER_REASON) do
if filter_reason == value then
Copy link
Copy Markdown
Member

@alex-courtis alex-courtis Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like node.hidden_stats could still be nil, as it's an optional member.

How about something really defensive like:

diff --git a/lua/nvim-tree/explorer/init.lua b/lua/nvim-tree/explorer/init.lua
index 0fdd46a..c42ffe0 100644
--- a/lua/nvim-tree/explorer/init.lua
+++ b/lua/nvim-tree/explorer/init.lua
@@ -389,9 +389,9 @@ function Explorer:populate_children(handle, cwd, node, project, parent)
           nodes_by_path[child.absolute_path] = true
           child:update_git_status(node_ignored, project)
         end
-      else
+      elseif node.hidden_stats then
         for reason, value in pairs(FILTER_REASON) do
-          if filter_reason == value then
+          if filter_reason == value and type(node.hidden_stats[reason]) == "number" then
             node.hidden_stats[reason] = node.hidden_stats[reason] + 1
           end
         end

Copy link
Copy Markdown
Contributor Author

@bafto bafto Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented it and it works for me as well.
I only have this issue on windows so this defensive version might be better to not break anything on linux.

if filter_reason == value and type(node.hidden_stats[reason]) == "number" then
node.hidden_stats[reason] = node.hidden_stats[reason] + 1
end
end
Expand Down