Skip to content

fix: avoid some unnecessary explorer reloads#1830

Closed
D0ot wants to merge 0 commit into
nvim-tree:masterfrom
D0ot:master
Closed

fix: avoid some unnecessary explorer reloads#1830
D0ot wants to merge 0 commit into
nvim-tree:masterfrom
D0ot:master

Conversation

@D0ot
Copy link
Copy Markdown
Contributor

@D0ot D0ot commented Dec 16, 2022

it seems that the reload is unnecessary when renderer.config.highlight_opened_files is "none".

The PR is made because I find a problem when using Telescope.
When in a large codebase, Telescope causes a lot of BufUnload events when it close, which makes my nvim stuck for seconds....

Copy link
Copy Markdown
Collaborator

@chomosuke chomosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Tested and works as expected :)

Comment thread lua/nvim-tree.lua
Comment thread lua/nvim-tree.lua Outdated
Comment thread lua/nvim-tree.lua Outdated
@chomosuke
Copy link
Copy Markdown
Collaborator

On a side note, you can run scripts/setup-hooks.sh to setup a commit hook and prevent accidentally committing changes without passing stylua and luacheck. :)

Comment thread lua/nvim-tree.lua Outdated
@alex-courtis
Copy link
Copy Markdown
Member

#1843 provides some more avoidance of reloads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants