Floating: Cannot close last window

[geril07]

Description

Error when deleting opened file with floating tree window.

2023-10-18.09-42-00.mp4

Neovim version

NVIM v0.10.0-dev-9f32deb
Build type: Release
LuaJIT 2.1.1696795921

Operating system and version

Fedora 6.5.5-200.fc38.x86_64

Windows variant

No response

nvim-tree version

40b9b88

Clean room replication

vim.g.loaded_netrw = 1
vim.g.loaded_netrwPlugin = 1

vim.cmd([[set runtimepath=$VIMRUNTIME]])
vim.cmd([[set packpath=/tmp/nvt-min/site]])
local package_root = "/tmp/nvt-min/site/pack"
local install_path = package_root .. "/packer/start/packer.nvim"
local function load_plugins()
	require("packer").startup({
		{
			"wbthomason/packer.nvim",
			"nvim-tree/nvim-tree.lua",
			"nvim-tree/nvim-web-devicons",
			-- ADD PLUGINS THAT ARE _NECESSARY_ FOR REPRODUCING THE ISSUE
		},
		config = {
			package_root = package_root,
			compile_path = install_path .. "/plugin/packer_compiled.lua",
			display = { non_interactive = true },
		},
	})
end
if vim.fn.isdirectory(install_path) == 0 then
	print("Installing nvim-tree and dependencies.")
	vim.fn.system({ "git", "clone", "--depth=1", "https://github.com/wbthomason/packer.nvim", install_path })
end
load_plugins()
require("packer").sync()
vim.cmd([[autocmd User PackerComplete ++once echo "Ready!" | lua setup()]])
vim.opt.termguicolors = true
vim.opt.cursorline = true

local width_ratio = 0.5
local height_ratio = 0.8

-- MODIFY NVIM-TREE SETTINGS THAT ARE _NECESSARY_ FOR REPRODUCING THE ISSUE
_G.setup = function()
	require("nvim-tree").setup({
		view = {
			float = {
				enable = true,
				quit_on_focus_loss = false,
				open_win_config = function()
					local screen_w = vim.opt.columns:get()
					local screen_h = vim.opt.lines:get() - vim.opt.cmdheight:get()

					local window_w = screen_w * width_ratio
					local window_h = screen_h * height_ratio
					local window_w_int = math.floor(window_w)
					local window_h_int = math.floor(window_h)
					local center_x = (screen_w - window_w) / 2
					local center_y = ((vim.opt.lines:get() - window_h) / 2) - vim.opt.cmdheight:get()
					return {
						border = "rounded",
						relative = "editor",
						row = center_y,
						col = center_x,
						width = window_w_int,
						height = window_h_int,
					}
				end,
			},
		},
		actions = {
			open_file = {
				quit_on_open = true,
			},
		},
	})
end

Steps to reproduce

1. nvim -nu /tmp/nvt-min.lua
2. :NvimTreeFocus
3. create file
4. open file
5. :NvimTreeFocus
6. Delete file

Expected behavior

No response

Actual behavior

No response

[alex-courtis]

Replicated.

Also occurs when quit_on_open = false

[geril07]

Seems to work fine with the following patch:

diff --git a/lua/nvim-tree/actions/fs/remove-file.lua b/lua/nvim-tree/actions/fs/remove-file.lua
index abc94d4..3e00f0d 100644
--- a/lua/nvim-tree/actions/fs/remove-file.lua
+++ b/lua/nvim-tree/actions/fs/remove-file.lua
@@ -9,7 +9,7 @@ local M = {
 }
 
 local function close_windows(windows)
-  if view.View.float.enable and #vim.api.nvim_list_wins() == 1 then
+  if view.View.float.enable then
     return
   end
 
@@ -22,17 +22,17 @@ end
 
 local function clear_buffer(absolute_path)
   local bufs = vim.fn.getbufinfo { bufloaded = 1, buflisted = 1 }
+  local tree_winnr = vim.api.nvim_get_current_win()
   for _, buf in pairs(bufs) do
     if buf.name == absolute_path then
       if buf.hidden == 0 and (#bufs > 1 or view.View.float.enable) then
-        local winnr = vim.api.nvim_get_current_win()
         vim.api.nvim_set_current_win(buf.windows[1])
         vim.cmd ":bn"
-        if not view.View.float.enable then
-          vim.api.nvim_set_current_win(winnr)
-        end
       end
       vim.api.nvim_buf_delete(buf.bufnr, { force = true })
+      if not view.View.float.quit_on_focus_loss then
+        vim.api.nvim_set_current_win(tree_winnr)
+      end
       if M.config.actions.remove_file.close_window then
         close_windows(buf.windows)
       end

I guess i broke some things which i dont use, but for me it works fine.
Or maybe adjust and #vim.api.nvim_list_wins() == 1 to 2/<3

[alex-courtis]

That looks pretty good @geril2207, what's broken?

I'd be most grateful if you could create a PR and we fix the broken functionality.

[geril07]

@alex-courtis #2503, I am not familiar with all features but floating and separate buffer seems to work fine.