Make install.py reconfigure editable installs when build type changes#455
Merged
trxcllnt merged 5 commits intonv-legate:branch-22.12from Nov 4, 2022
Conversation
…t matches one of the `-d` names
…ikit-build bug (fixes nv-legate#372)
manopapad
pushed a commit
that referenced
this pull request
Mar 5, 2025
* Don't inherit from variant because GCC < 11 had a bug with it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
SKBUILD_CONFIGURE_OPTIONSandCMAKE_ARGSenvvars are the two ways to set CMake arguments inscikit-build.CMAKE_ARGSis set automatically byconda-build, and my understanding was thatscikit-buildmerges the values in bothCMAKE_ARGSandSKBUILD_CONFIGURE_OPTIONStogether... except apparently not.CMAKE_ARGS="..." pip install --editable .does reconfigure ifCMAKE_BUILD_TYPEchanges between builds.SKBUILD_CONFIGURE_OPTIONS="..." pip install --editable .doesn't reconfigure ifCMAKE_BUILD_TYPEchanges.🤔
Here's the build logs of 3
--editablebuilds run in a clean environment and in order:This PR changes
install.pyto set all CMake arguments viaCMAKE_ARGSinstead ofSKBUILD_CONFIGURE_OPTIONS.Fixes #372.