Add CMake build for C++ and scikit-build infrastructure for Python package installation#323
Merged
manopapad merged 240 commits intonv-legate:branch-22.10from Sep 21, 2022
Merged
Conversation
…_USE_GASNet=ON and -DGASNet_CONDUIT=mpi
* Add required realm/legion preincludes * Make compile definitions part of the public legate_core interface
…he version numbers
…ARCH and BUILD_MCPU logic
manopapad
reviewed
Aug 26, 2022
manopapad
reviewed
Aug 27, 2022
| - make | ||
| - zlib | ||
| - cmake>=3.24 | ||
| - ninja |
Contributor
There was a problem hiding this comment.
Do we need both make and ninja?
Contributor
There was a problem hiding this comment.
Some people may prefer make over ninja, but I'm fine going w/ only ninja.
manopapad
reviewed
Aug 27, 2022
manopapad
reviewed
Aug 27, 2022
manopapad
reviewed
Aug 29, 2022
| - openmpi | ||
| - c-compiler | ||
| - cxx-compiler | ||
| - gcc_linux-64 # [linux64] |
Contributor
There was a problem hiding this comment.
Do we need to specify gcc specifically? Especially if later we request llvm-openmp
Contributor
There was a problem hiding this comment.
IIRC, the compiler does not necessarily come with a specific openmp implementation, and package maintainers/users have a choice of which openmp implementation to use.
manopapad
reviewed
Sep 20, 2022
| # Get the `stubs/libcuda.so` path so we can set CMAKE_LIBRARY_PATH for FindCUDA.cmake | ||
|
|
||
| # Prefer users' CUDA_PATH envvar (if set) | ||
| set(_cuda_stubs "$ENV{CUDA_PATH}") |
Contributor
There was a problem hiding this comment.
Can we check in all cases that <candidate-dir>/stubs/libcuda.so exists before accepting it? e.g. something like
does ENV{CUDA_PATH}/stubs/libcuda.so exist?
if yes then _cuda_stubs += ENV{CUDA_PATH}/stubs otherwise:
does ENV{CUDA_LIB_PATH}/stubs/libcuda.so exist?
if yes then _cuda_stubs += ENV{CUDA_LIB_PATH}/stubs otherwise:
...
manopapad
pushed a commit
that referenced
this pull request
Mar 5, 2025
* Correct detachment from Python buffers * Documentation for create_store_from_buffer * Address review comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clone of #198 with special branch name so CI will test the legate.core and cunumeric PR's together.