Broaden add_scalar_arg type#306
Merged
bryevdv merged 2 commits intonv-legate:branch-22.07from Jul 20, 2022
bryevdv:bryanv/add_scalar_arg
Merged
Broaden add_scalar_arg type#306bryevdv merged 2 commits intonv-legate:branch-22.07from bryevdv:bryanv/add_scalar_arg
bryevdv merged 2 commits intonv-legate:branch-22.07from
bryevdv:bryanv/add_scalar_arg
Conversation
manopapad
reviewed
Jul 20, 2022
manopapad
approved these changes
Jul 20, 2022
manopapad
pushed a commit
that referenced
this pull request
Mar 5, 2025
Ignoring unrelated CI failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original type for
add_scalar_argwas too narrow, discovered in nv-legate/cupynumeric#438